Re: [PATCH v7 17/39] KVM: x86: hyper-v: L2 TLB flush

Subject: Re: [PATCH v7 17/39] KVM: x86: hyper-v: L2 TLB flush
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Tue, 21 Jun 2022 14:59:58 +0200
Cc: Sean Christopherson <seanjc@xxxxxxxxxx>, Maxim Levitsky <mlevitsk@xxxxxxxxxx>, Wanpeng Li <wanpengli@xxxxxxxxxxx>, Jim Mattson <jmattson@xxxxxxxxxx>, Michael Kelley <mikelley@xxxxxxxxxxxxx>, Siddharth Chandrasekaran <sidcha@xxxxxxxxx>, Yuan Yao <yuan.yao@xxxxxxxxxxxxxxx>, linux-hyperv@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20220613133922.2875594-18-vkuznets@redhat.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0

On 6/13/22 15:39, Vitaly Kuznetsov wrote:

-	tlb_flush_fifo = kvm_hv_get_tlb_flush_fifo(vcpu);
+	tlb_flush_fifo = kvm_hv_get_tlb_flush_fifo(vcpu, is_guest_mode(vcpu));

Any reason to add this parameter? It is always set tois_guest_mode(vcpu) and, even if it wasn't, I would add the parameterdirectly in patch 11.


Paolo

Follow-Ups:
- Re: [PATCH v7 17/39] KVM: x86: hyper-v: L2 TLB flush
  - From: Vitaly Kuznetsov

References:
- [PATCH v7 00/39] KVM: x86: hyper-v: Fine-grained TLB flush + L2 TLB flush features
  - From: Vitaly Kuznetsov
- [PATCH v7 17/39] KVM: x86: hyper-v: L2 TLB flush
  - From: Vitaly Kuznetsov