On 5/29/2021 2:55 PM, Wei Liu wrote: > On Fri, May 28, 2021 at 03:43:32PM -0700, Nuno Das Neves wrote: > [...] >> int mshv_synic_init(unsigned int cpu) >> { >> union hv_synic_simp simp; >> @@ -30,7 +126,7 @@ int mshv_synic_init(unsigned int cpu) >> *msg_page = memremap(simp.base_simp_gpa << HV_HYP_PAGE_SHIFT, >> HV_HYP_PAGE_SIZE, >> MEMREMAP_WB); >> - if (!msg_page) { >> + if (!(*msg_page)) { > > This hunk belongs to the previous patch in which you introduced this > function, not this one. > > Wei. > Hmm I think I messed up a rebase. Thanks for catching it!