On 5/28/2021 5:01 PM, Randy Dunlap wrote: > On 5/28/21 3:43 PM, Nuno Das Neves wrote: >> Introduce a barebones module file for the mshv API. >> Introduce CONFIG_HYPERV_ROOT_API for controlling compilation of mshv. >> >> Co-developed-by: Lillian Grassin-Drake <ligrassi@xxxxxxxxxxxxx> >> Signed-off-by: Lillian Grassin-Drake <ligrassi@xxxxxxxxxxxxx> >> Signed-off-by: Nuno Das Neves <nunodasneves@xxxxxxxxxxxxxxxxxxx> >> --- > > Hi, > >> diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig >> index 66c794d92391..d618b1fab2bb 100644 >> --- a/drivers/hv/Kconfig >> +++ b/drivers/hv/Kconfig >> @@ -27,4 +27,22 @@ config HYPERV_BALLOON >> help >> Select this option to enable Hyper-V Balloon driver. >> >> +config HYPERV_ROOT_API >> + tristate "Microsoft Hypervisor root partition interfaces: /dev/mshv" >> + depends on HYPERV >> + help >> + Provides access to interfaces for managing guest virtual machines >> + running under the Microsoft Hypervisor. >> + >> + These interfaces will only work when Linux is running as root >> + partition on the Microsoft Hypervisor. >> + >> + The interfaces are provided via a device named /dev/mshv. >> + >> + To compile this as a module, choose M here. >> + The module is named mshv. > > ^^^^^^^^^^^^^ > > Please follow coding-style for Kconfig files: > > (from Documentation/process/coding-style.rst, section 10): > > For all of the Kconfig* configuration files throughout the source tree, > the indentation is somewhat different. Lines under a ``config`` definition > are indented with one tab, while help text is indented an additional two > spaces. > Oops, thanks for catching that! >> + >> + If unsure, say N. >> + >> + >> endmenu > > thanks. >