> From: linux-hyperv-owner@xxxxxxxxxxxxxxx > <linux-hyperv-owner@xxxxxxxxxxxxxxx> On Behalf Of Randy Dunlap > Sent: Tuesday, July 2, 2019 8:25 PM > To: Matthew Wilcox <willy@xxxxxxxxxxxxx> > Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>; linux-hyperv@xxxxxxxxxxxxxxx; Jake > Oshins <jakeo@xxxxxxxxxxxxx>; KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang > Zhang <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger > <sthemmin@xxxxxxxxxxxxx>; Sasha Levin <sashal@xxxxxxxxxx>; linux-pci > <linux-pci@xxxxxxxxxxxxxxx>; Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Subject: Re: [PATCH] PCI: hv: fix pci-hyperv build, depends on SYSFS > > On 7/2/19 5:15 PM, Matthew Wilcox wrote: > > On Tue, Jul 02, 2019 at 04:24:30PM -0700, Randy Dunlap wrote: > >> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > >> > >> Fix build errors when building almost-allmodconfig but with SYSFS > >> not set (not enabled). Fixes these build errors: > >> > >> ERROR: "pci_destroy_slot" [drivers/pci/controller/pci-hyperv.ko] undefined! > >> ERROR: "pci_create_slot" [drivers/pci/controller/pci-hyperv.ko] undefined! > >> > >> drivers/pci/slot.o is only built when SYSFS is enabled, so > >> pci-hyperv.o has an implicit dependency on SYSFS. > >> Make that explicit. > > > > I wonder if we shouldn't rather provide no-op versions of > > pci_create|destroy_slot for when SYSFS is not set? > > > > Makes sense. I'm test-building that now. > > -- > ~Randy + Yuehaibing, who submitted a similar patch, which I guess is neglected at the end of the discussion last month: https://lkml.org/lkml/2019/5/31/559 https://lkml.org/lkml/2019/6/14/784 https://lkml.org/lkml/2019/6/15/24 Thanks, -- Dexuan
