On 7/2/19 5:15 PM, Matthew Wilcox wrote: > On Tue, Jul 02, 2019 at 04:24:30PM -0700, Randy Dunlap wrote: >> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >> >> Fix build errors when building almost-allmodconfig but with SYSFS >> not set (not enabled). Fixes these build errors: >> >> ERROR: "pci_destroy_slot" [drivers/pci/controller/pci-hyperv.ko] undefined! >> ERROR: "pci_create_slot" [drivers/pci/controller/pci-hyperv.ko] undefined! >> >> drivers/pci/slot.o is only built when SYSFS is enabled, so >> pci-hyperv.o has an implicit dependency on SYSFS. >> Make that explicit. > > I wonder if we shouldn't rather provide no-op versions of > pci_create|destroy_slot for when SYSFS is not set? > Makes sense. I'm test-building that now. -- ~Randy
