On 10/29/24 20:29, Ming Yu wrote:
Dear Jonathan, Thanks you for your comments, I tested your suggestion in both the MFD driver and the IIO driver, and the iio-hwmon bridge worked well. On the other hand, my requirements involve accessing thermal sensors, voltage sensors and tachometers, so I should implement it in this HWMON drive, right?
Duplicate drivers for the same hardware is not acceptable. I see that so far only pwm and fan control is implemented in the hwmon driver. There is no public documentation for NCT6694, so it is difficult to evaluate the chip's capabilities. The summary doesn't even mention fan speed readings, meaning pretty much everything is guesswork. Either case, I do see that you also implemented a pwm driver which _does_ duplicate hwmon functionality. Sorry, that is a no-go. Again, we can not have multiple drivers controlling the same hardware. A pwm controller implemented in a hwmon device is supposed to be limited to fan control. It looks like the pwm controller implemented in the NCT6694 is a generic pwm controller. It is not appropriate to have a hwmon driver for such a pwm controller. Guenter
