Re: [PATCH] dt-bindings: hwmon: Add adt7462

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 19/09/2024 17:39, Krzysztof Kozlowski wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.]


On 19/09/2024 11:43, Chanh Nguyen wrote:
+properties:
+  compatible:
+    const: onnn,adt7462
+
+  reg:
+    maxItems: 1
+
+  resets:
+    maxItems: 1

How would this work? 'resets' generally is used for on-chip devices and
a reset controller. That doesn't exist at the board level. A standalone
device typically uses a GPIO lines if there's a s/w controlled reset.
That would be the 'reset-gpios' property.


Thank Rob for your comments! The ADT7462 includes an active low reset
pin (Pin #14).

I'll change 'resets' into the 'reset-gpios' property.

The example in the binding will be

The question how did it work in the first place is still valid... I
think we might benefit from asking people to post their upstreamed DTS.
Otherwise we will take broken or half-baked bindings, because we never
saw the bigger picture. :(


Thank Krzysztof,

I saw the ADT7462 includes an active low reset pin (Pin #14) to reset device via I/O pin. So, I introduced a reset property follow the device datasheet.

But the adt7462 driver has not yet implemented this property. My platform also doesn't design this pin on board, so I don't need it at least now.

Anyway, I hope Rob, Guenter and Krzysztof can give me advice on whether I should add this property to the binding?

Thanks,
Chanh

Best regards,
Krzysztof





[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux