Re: [PATCH 1/2] hwmon: (ina2xx) Add support for has_alerts configuration flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/19/24 01:30, Tzung-Bi Shih wrote:
On Thu, Sep 12, 2024 at 05:31:44PM -0700, Guenter Roeck wrote:
Add configuration flag indicating if the chip supports alerts and limits
to prepare for adding INA260 support.

Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>

@@ -155,6 +156,7 @@ static const struct ina2xx_config ina2xx_config[] = {
  		.bus_voltage_shift = 3,
  		.bus_voltage_lsb = 4000,
  		.power_lsb_factor = 20,
+		.has_alerts = false,

No strong preference: or just don't set it.

In situations like this I prefer to explicitly set the value to indicate that
it wasn't forgotten.

Thanks a lot for the reviews!

Guenter





[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux