On Wed, Aug 28, 2024 at 11:05:35AM -0700, Nathan Chancellor wrote:
> clang warns (or errors due to CONFIG_WERROR):
>
> drivers/hwmon/oxp-sensors.c:481:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
> drivers/hwmon/oxp-sensors.c:553:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
> drivers/hwmon/oxp-sensors.c:556:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
> drivers/hwmon/oxp-sensors.c:607:3: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
>
> Clang is a little more pedantic than GCC, which does not warn when
> falling through to a case that is just break or return. Clang's version
> is more in line with the kernel's own stance in deprecated.rst, which
> states that all switch/case blocks must end in either break,
> fallthrough, continue, goto, or return. Add the missing breaks to
> silence the warnings.
>
> Fixes: b82b38a49926 ("hwmon: (oxp-sensors) Add support for multiple new devices.")
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
Applied.
Thanks,
Guenter
