Re: [PATCH v4 1/1] dt-bindings: hwmon: Convert ltc2978.txt to yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 28, 2024 at 12:40:59PM -0700, Guenter Roeck wrote:
> On 8/28/24 11:35, Frank Li wrote:
> > On Wed, Aug 28, 2024 at 10:06:25AM -0700, Guenter Roeck wrote:
> > > On 8/28/24 09:41, Frank Li wrote:
> > > > Convert binding doc ltc2978.txt to yaml format.
> > > > Additional change:
> > > > - add i2c node.
> > > > - basic it is regulator according to example, move it under regulator.
> > > >
> > > > Fix below warning:
> > > > arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: /soc/i2c@2000000/i2c-mux@77/i2c@2/regulator@5c:
> > > > 	failed to match any schema with compatible: ['lltc,ltc3882']
> > > >
> > > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > > > ---
> > > > Change from v3 to v4
> > > > - keep under hwmon directory.
> > > > Change from v2 to v3
> > > > - put my name into maintainers.
> > > > change from v1 to v2
> > > > - maintainer change to Mark Brown <broonie@xxxxxxxxxx> (regulator maintainer)
> > > > - update title to (from ltc2978 data sheet).
> > > > octal, digital power-supply monitor, supervisor, sequencer, and margin controller.
> > > > ---
> > > >    .../bindings/hwmon/lltc,ltc2972.yaml          | 94 +++++++++++++++++++
> > > >    .../devicetree/bindings/hwmon/ltc2978.txt     | 62 ------------
> > >
> > > I still fail to understand the rationale for renaming the file from ltc2978
> > > to ltc2972. I can see that 2972 is currently the alphabetically first supported
> > > chip, but that is, in my opinion, irrelevant, and it will change.
> >
> > Conor suggest use one of compatbile string as filename. I random pick one.
> > I am not care about filename. If you like, I can use lltc,ltc2978.yaml
> > or other filename.
> >
>
> The rename results in a disconnect between driver name and the associated
> devicetree file. I fail to see the point of introducing that disconnect.

what's name do you prefered? lltc,ltc2978.yaml?

Frank

>
> Guenter
>




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux