On 7/21/24 20:30, Tzung-Bi Shih wrote:
On Sun, Jul 21, 2024 at 12:35:06PM -0700, Guenter Roeck wrote:
Chips reporting overcurrent alarms report it in the second alarm register.
I can't understand the sentence. Not sure whether it needs to be rephrased or
not. s/overcurrent/overvoltage/.
No, it is over-current. Not all chips support current measurements.
Those who do support it also support reporting over-current alarms.
Over-current alarms are reported in the second alarm register.
Do you have a suggestion for better wording ?
Thanks,
Guenter
That means the second alarm register has to be read, even if the chip only
supports 8 or fewer ADC channels.
MAX16067 and MAX16068 report undervoltage and overvoltage alarms in
separate registers. Fold register contents together to report both with
the existing alarm attribute. This requires actually storing the chip type
in struct max16065_data. Rename the variable 'chip' to match the variable
name used in the probe function.
Fixes: f5bae2642e3d ("hwmon: Driver for MAX16065 System Manager and compatibles")
Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>
