On Fri, Apr 05, 2024 at 06:04:16PM -0700, Ricardo Neri wrote: > The Intel Software Development manual defines states the temperature > digital readout as the bits [22:16] of the IA32_[PACKAGE]_THERM_STATUS > registers. In recent processor, however, the range is [23:16]. Use a > model-specific bitmask to extract the temperature readout correctly. > > Instead of re-implementing model checks, extract the correct bitmask > using the intel_tcc library. Add an 'imply' weak reverse dependency on > CONFIG_INTEL_TCC. This captures the dependency and lets user to unselect > them if they are so inclined. In such case, the bitmask used for the > digital readout is [22:16] as specified in the Intel Software Developer's > manual. > > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@xxxxxxxxxxxxxxx> > --- > Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> > Cc: Lukasz Luba <lukasz.luba@xxxxxxx> > Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> > Cc: linux-hwmon@xxxxxxxxxxxxxxx > Cc: linux-pm@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Cc: stable@xxxxxxxxxxxxxxx # v6.7+ > --- > drivers/hwmon/Kconfig | 1 + > drivers/hwmon/coretemp.c | 6 +++++- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index 83945397b6eb..11d72b3009bf 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -847,6 +847,7 @@ config SENSORS_I5500 > config SENSORS_CORETEMP > tristate "Intel Core/Core2/Atom temperature sensor" > depends on X86 > + imply INTEL_TCC I do not think it is appropriate to make a hardware monitoring driver depend on the thermal subsystem. NAK in the current form. Guenter
