Re: [PATCH RFC 7/7] Input: mpr121: Use devm_regulator_get_enable_get_voltage()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Lechner <dlechner@xxxxxxxxxxxx>
Subject: Re: [PATCH RFC 7/7] Input: mpr121: Use devm_regulator_get_enable_get_voltage()
From: Jonathan Cameron <jic23@xxxxxxxxxx>
Date: Thu, 28 Mar 2024 14:21:57 +0000
Cc: Jonathan Corbet <corbet@xxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Jean Delvare <jdelvare@xxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, Support Opensource <support.opensource@xxxxxxxxxxx>, Cosmin Tanislav <cosmin.tanislav@xxxxxxxxxx>, Lars-Peter Clausen <lars@xxxxxxxxxx>, Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>, Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-hwmon@xxxxxxxxxxxxxxx, linux-iio@xxxxxxxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, linux-input@xxxxxxxxxxxxxxx
In-reply-to: <20240327-regulator-get-enable-get-votlage-v1-7-5f4517faa059@baylibre.com>
References: <20240327-regulator-get-enable-get-votlage-v1-0-5f4517faa059@baylibre.com> <20240327-regulator-get-enable-get-votlage-v1-7-5f4517faa059@baylibre.com>

On Wed, 27 Mar 2024 18:18:56 -0500
David Lechner <dlechner@xxxxxxxxxxxx> wrote:

> We can reduce boilerplate code by using
> devm_regulator_get_enable_get_voltage().
> 
> Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
LGTM though you may want to bring an error message back if you drop the
prints from the regulator functions.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

References:
- [PATCH RFC 0/7] regulator: new APIs for voltage reference supplies
  - From: David Lechner
- [PATCH RFC 7/7] Input: mpr121: Use devm_regulator_get_enable_get_voltage()
  - From: David Lechner

Prev by Date: Re: [PATCH RFC 3/7] hwmon: (da9052) Use devm_regulator_get_enable_get_voltage()
Next by Date: Re: [PATCH RFC 3/7] hwmon: (da9052) Use devm_regulator_get_enable_get_voltage()
Previous by thread: [PATCH RFC 7/7] Input: mpr121: Use devm_regulator_get_enable_get_voltage()
Next by thread: [PATCH v5] hwmon:Add EC Chip driver for Lenovo ThinkStation motherboards
Index(es):
- Date
- Thread

[Index of Archives] [LM Sensors] [Linux Sound] [ALSA Users] [ALSA Devel] [Linux Audio Users] [Linux Media] [Kernel] [Gimp] [Yosemite News] [Linux Media]