On Mon, Mar 25, 2024 at 09:29:11AM -0700, Guenter Roeck wrote: > On Mon, Mar 25, 2024 at 02:07:42PM +0200, Andy Shevchenko wrote: > > The newly introduced SWAP() macro is quite generic by naming, but > > moreover it's a repetition of the existing __assign_bit(). > > With this applied, add a missing bits.h (via now required bitops.h). > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Not sure if I like __assign_bit() more than SWAP(), To add to the mess, we have swap() already defined globally. This one steps on our toes. > but at least it is "standard". Applied. Thank you! -- With Best Regards, Andy Shevchenko