On Wed, Feb 21, 2024 at 11:06:53AM PST, Conor Dooley wrote:
On Mon, Feb 19, 2024 at 07:13:33AM -0800, Guenter Roeck wrote:
On 2/19/24 06:48, Conor Dooley wrote:
> On Sat, Feb 17, 2024 at 10:00:30PM +0000, Conor Dooley wrote:
> > On Wed, Feb 14, 2024 at 11:43:39AM -0800, Guenter Roeck wrote:
> > > If a chip only provides a single regulator, it should be named 'vout'
> > > and not 'vout0'. Declare regulators for chips with a single ouput using
> > > PMBUS_REGULATOR_ONE() to make that happen.
> >
> > If we're gonna do this, we should go ahead and document each of these
> > regulators. If Naresh sends a v2 for the tda, I could do the others.
>
> As it turns out, the infineon devices in question are not PMICs, but
> regulators themselves. I think something like the following is what we
> need. Perhaps Zev or the 9elements guys can comment.
>
IMO The lm25066 patch should be separate.
It should already be a pair of changes - one for the infineon stuff and
another for the ti devices:
> commit 9cf2671c0b98c0a0dd599fe9152985d1320bf320
> Author: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Date: Mon Feb 19 14:24:48 2024 +0000
>
> dt-bindings: regulator: promote infineon buck converters to their own binding
> These devices may need to make use of the common regulator properties,
> but these are not permitted while only documented in
> trivial-devices.yaml
> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> commit 597739840d2bc95ebb884d7f5fc4f3cc206d9af6
> Author: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Date: Mon Feb 19 13:29:12 2024 +0000
>
> dt-bindings: hwmon/pmbus: ti,lm25066: document regulators
> All devices documented in the lm25066 binding are intended for use with
> a regulator, be that for purely monitoring purposes (lm25056) or, for
> the other devices, as the controller of that regulator. The binding does
> not currently allow regulator child nodes, so add one.
> Each of these devices interacts with only a single regulator and
> documentation refers to it as "Vout", hence the choice of child node
> name.
> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
This looks fine to me -- as far as the lm25066 patch goes,
Acked-by: Zev Weiss <zev@xxxxxxxxxxxxxxxxx>
Thanks,
Zev
