Re: [PATCH 0/3] hwmon: (pmbus) Use PMBUS_REGULATOR_ONE to declare regulators with single output

[Guenter Roeck <linux@xxxxxxxxxxxx>]

On 2/19/24 06:48, Conor Dooley wrote:
> On Sat, Feb 17, 2024 at 10:00:30PM +0000, Conor Dooley wrote:
> > On Wed, Feb 14, 2024 at 11:43:39AM -0800, Guenter Roeck wrote:
> > > If a chip only provides a single regulator, it should be named 'vout'
> > > and not 'vout0'. Declare regulators for chips with a single ouput using
> > > PMBUS_REGULATOR_ONE() to make that happen.
> >
> > If we're gonna do this, we should go ahead and document each of these
> > regulators. If Naresh sends a v2 for the tda, I could do the others.
>
> As it turns out, the infineon devices in question are not PMICs, but
> regulators themselves. I think something like the following is what we
> need. Perhaps Zev or the 9elements guys can comment.
IMO The lm25066 patch should be separate.

Guenter

> Cheers,
> Conor.
>
> commit 9cf2671c0b98c0a0dd599fe9152985d1320bf320
> Author: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Date:   Mon Feb 19 14:24:48 2024 +0000
>
>      dt-bindings: regulator: promote infineon buck converters to their own binding
>      
>      These devices may need to make use of the common regulator properties,
>      but these are not permitted while only documented in
>      trivial-devices.yaml
>      
>      Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>
> diff --git a/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
> new file mode 100644
> index 000000000000..bb0114f7e13f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/infineon,ir38060.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Infineon Buck Regulators with PMBUS interfaces
> +
> +maintainers:
> +  - Not Me.
> +
> +allOf:
> +  - $ref: regulator.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - infineon,ir38060
> +      - infineon,ir38064
> +      - infineon,ir38164
> +      - infineon,ir38263
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      regulator@34 {
> +        compatible = "infineon,ir38060";
> +        reg = <0x34>;
> +
> +        regulator-min-microvolt = <437500>;
> +        regulator-max-microvolt = <1387500>;
> +      };
> +    };
> +
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 9cdd5a534120..e07be7bf8395 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -130,14 +130,6 @@ properties:
>             - infineon,dps310
>               # Infineon IR36021 digital POL buck controller
>             - infineon,ir36021
> -            # Infineon IR38060 Voltage Regulator
> -          - infineon,ir38060
> -            # Infineon IR38064 Voltage Regulator
> -          - infineon,ir38064
> -            # Infineon IR38164 Voltage Regulator
> -          - infineon,ir38164
> -            # Infineon IR38263 Voltage Regulator
> -          - infineon,ir38263
>               # Infineon IRPS5401 Voltage Regulator (PMIC)
>             - infineon,irps5401
>               # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor
>
> commit 597739840d2bc95ebb884d7f5fc4f3cc206d9af6
> Author: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Date:   Mon Feb 19 13:29:12 2024 +0000
>
>      dt-bindings: hwmon/pmbus: ti,lm25066: document regulators
>      
>      All devices documented in the lm25066 binding are intended for use with
>      a regulator, be that for purely monitoring purposes (lm25056) or, for
>      the other devices, as the controller of that regulator. The binding does
>      not currently allow regulator child nodes, so add one.
>      
>      Each of these devices interacts with only a single regulator and
>      documentation refers to it as "Vout", hence the choice of child node
>      name.
>      
>      Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml > index da8292bc32f5..4373e9c86e54 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml
> @@ -34,6 +34,18 @@ properties:
>         Shunt (sense) resistor value in micro-Ohms
>       default: 1000
>   
> +  regulators:
> +    type: object
> +
> +    properties:
> +      vout:
> +        $ref: /schemas/regulator/regulator.yaml#
> +        type: object
> +
> +        unevaluatedProperties: false
> +
> +    additionalProperties: false
> +
>   required:
>     - compatible
>     - reg