Am 2/5/2024 um 1:52 PM schrieb Ivor Wanders:
Missing 'depends on SURFACE_AGGREGATOR' in the Kconfig.
Unfortunately, `SURFACE_AGGREGATOR` is what was in the Kconfig, it should
have been `SURFACE_AGGREGATOR_BUS` instead, that's where the missing symbol
is defined. I wonder if that split still provides value, but that's
off topic for this thread.
I see that c3747f28ebcefe34d6ea2e4eb2d3bb6b9d574b5f is no longer in the
branch, but 42c88a7d1474b6f6e53acca3522d179d3c9b1c6f is where this is
already changed over.
Thanks again Guenter!
~Ivor
It should actually depend on both. Since SURFACE_AGGREGATOR_BUS is just
a bool, depending on it alone will allow the module to be built in when
SURFACE_AGGREGATOR has not been built in. Which I assume is what caused
this issue.
As for why it's separate: Earlier (gen 4) Surface devices don't require
the bus functionality and have (most of) their client devices defined in
ACPI. But since nowadays all new devices need the bus, we might as well
remove that distinction.
Regards,
Max
