On 2/5/24 07:42, kernel test robot wrote:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
head: fb0833325ac45560e6b62681c77bed56bcfc20a9
commit: c3747f28ebcefe34d6ea2e4eb2d3bb6b9d574b5f [13/34] hwmon: add fan speed monitoring driver for Surface devices
config: x86_64-randconfig-121-20240205 (https://download.01.org/0day-ci/archive/20240205/202402051456.JOjQbD3G-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240205/202402051456.JOjQbD3G-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402051456.JOjQbD3G-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
ld: drivers/hwmon/surface_fan.o: in function `surface_fan_init':
drivers/hwmon/surface_fan.c:87: undefined reference to `__ssam_device_driver_register'
ld: drivers/hwmon/surface_fan.o: in function `surface_fan_exit':
drivers/hwmon/surface_fan.c:87: undefined reference to `ssam_device_driver_unregister'
vim +87 drivers/hwmon/surface_fan.c
78
79 static struct ssam_device_driver surface_fan = {
80 .probe = surface_fan_probe,
81 .match_table = ssam_fan_match,
82 .driver = {
83 .name = "surface_fan",
84 .probe_type = PROBE_PREFER_ASYNCHRONOUS,
85 },
86 };
> 87 module_ssam_device_driver(surface_fan);
88
Missing 'depends on SURFACE_AGGREGATOR' in the Kconfig. Should have
spotted this during review, sorry.
I can prepare a patch once I'm back from my day-job, unless someone else
sent a fix by then.
Regards,
Max
