On Thu, 29 Jun 2023 07:40:00 -0700, Andi Shyti wrote: > Hi Andi, > > Expose the card reactive critical (I1) power. I1 is exposed as > > power1_crit in microwatts (typically for client products) or as > > curr1_crit in milliamperes (typically for server). > > This is port from i915 hwmon. > > Should this, then be a more generic framework for more gpu > drivers? Now we are having some code duplication. There are several subsystems where we will see such duplication. These include things like PMU, OA which are either on the mailing list of in preparation. You can argue there is already code duplication between XE and i915, it's just hidden in xe way of doing things. The only way to avoid code duplication would be to invent sharing code between i915 and xe as display has done. It may be possible in some cases but in others sharing code will make matters worse for both xe and i915. So in general I am not seeing a way around "code duplication". Thanks. -- Ashutosh
