On Fri, May 26, 2023 at 09:39:38PM +0500, Osama Muhammad wrote: > This patch removes the error checking for debugfs_create_dir > in adm1266.c. This is because the debugfs_create_dir() does not > return NULL but an ERR_PTR after an error. > The DebugFS kernel API is developed in a way that the > caller can safely ignore the errors that occur during > the creation of DebugFS nodes.The debugfs Api handles > it gracefully. The check is unnecessary. > > Link to the comment above debugfs_create_dir: > https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L565 > > Signed-off-by: Osama Muhammad <osmtendev@xxxxxxxxx> Applied. Thanks, Guenter > --- > changes since v2 > -Added more descriptive commit message. > > changes since v1 > -In v1 the IS_ERR was used for error checking which is dropped now. > --- > drivers/hwmon/pmbus/adm1266.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c > index 1ac2b2f4c570..184d75269d2b 100644 > --- a/drivers/hwmon/pmbus/adm1266.c > +++ b/drivers/hwmon/pmbus/adm1266.c > @@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data) > return; > > data->debugfs_dir = debugfs_create_dir(data->client->name, root); > - if (!data->debugfs_dir) > - return; > > debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir, > adm1266_state_read);
