On Fri, May 26, 2023 at 08:49:06PM +0500, Osama Muhammad wrote: > This patch removes the error checking for debugfs_create_dir > in ucd9000.c. This is because the debugfs_create_dir() does not > return NULL but an ERR_PTR after an error. > The DebugFS kernel API is developed in a way that the > caller can safely ignore the errors that occur during > the creation of DebugFS nodes.The debugfs Api handles > it gracefully. The check is unnecessary. > > Link to the comment above debugfs_create_dir: > https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L565 > > Signed-off-by: Osama Muhammad <osmtendev@xxxxxxxxx> Applied. Thanks, Guenter > --- > changes since v1 > -Added more descriptive commit message. > --- > drivers/hwmon/pmbus/ucd9000.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/hwmon/pmbus/ucd9000.c b/drivers/hwmon/pmbus/ucd9000.c > index 3daaf2237832..73559afa8ba7 100644 > --- a/drivers/hwmon/pmbus/ucd9000.c > +++ b/drivers/hwmon/pmbus/ucd9000.c > @@ -512,8 +512,6 @@ static int ucd9000_init_debugfs(struct i2c_client *client, > return -ENOENT; > > data->debugfs = debugfs_create_dir(client->name, debugfs); > - if (!data->debugfs) > - return -ENOENT; > > /* > * Of the chips this driver supports, only the UCD9090, UCD90160,
