Hi
On 19-04-2023 02:34 pm, Krzysztof Kozlowski wrote:
On 19/04/2023 11:00, Naresh Solanki wrote:
Hi Krysztof,
On 18-04-2023 09:47 pm, Krzysztof Kozlowski wrote:
On 18/04/2023 13:32, Naresh Solanki wrote:
Add Devicetree binding documentation for Maxim MAX6639 temperature
monitor with PWM fan-speed controller.
Subject: drop second/last, redundant "binding for". The "dt-bindings"
prefix is already stating that these are bindings.
Ack
Signed-off-by: Naresh Solanki <Naresh.Solanki@xxxxxxxxxxxxx>
---
.../bindings/hwmon/maxim,max6639.yaml | 55 +++++++++++++++++++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
new file mode 100644
index 000000000000..20b28cd36555
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+
Drop blank line
Ack
This is v9. Where is the changelog? Where is previous authorship? At
least some parts of it? Why this has less properties than old one? Why
this has more mistakes than the old one? Go to previous patch... or fix
everything which was already fixed.
This patch is to add basic dt support only hence no additional properties.
How does that answer my questions?
This patch is intended to add dt support for the max6639 driver, and I
did not take it from previous patches. As this is a basic dt binding, it
has fewer properties compared to the old one.
I have used v8 as a reference for this patch, and I will review it again
to make sure I have not missed anything. Will ensure to fix them in the
next patch.
Although I cannot go back to the previous patch, I will address and fix
any issues in this patchset.
Best regards,
Krzysztof
Regards,
Naresh
