Re: [PATCH 1/2] dt-bindings: hwmon: Add binding for max6639

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/04/2023 11:00, Naresh Solanki wrote:
> Hi Krysztof,
> 
> On 18-04-2023 09:47 pm, Krzysztof Kozlowski wrote:
>> On 18/04/2023 13:32, Naresh Solanki wrote:
>>> Add Devicetree binding documentation for Maxim MAX6639 temperature
>>> monitor with PWM fan-speed controller.
>>
>> Subject: drop second/last, redundant "binding for". The "dt-bindings"
>> prefix is already stating that these are bindings.
> Ack
>>
>>>
>>> Signed-off-by: Naresh Solanki <Naresh.Solanki@xxxxxxxxxxxxx>
>>> ---
>>>   .../bindings/hwmon/maxim,max6639.yaml         | 55 +++++++++++++++++++
>>>   1 file changed, 55 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
>>> new file mode 100644
>>> index 000000000000..20b28cd36555
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
>>> @@ -0,0 +1,55 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +
>>
>> Drop blank line
> Ack
>>
>> This is v9. Where is the changelog? Where is previous authorship? At
>> least some parts of it? Why this has less properties than old one? Why
>> this has more mistakes than the old one? Go to previous patch... or fix
>> everything which was already fixed.
> This patch is to add basic dt support only hence no additional properties.

How does that answer my questions?

Best regards,
Krzysztof




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux