RE: [PATCH v8 3/4] dt-bindings: hwmon: Add bindings for max31760

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Fri, Sep 09, 2022 at 11:26:29AM -0500, Rob Herring wrote:
> > On Fri, 09 Sep 2022 16:37:17 +0300, Ibrahim Tilki wrote:
> > > Adding bindings for Analog Devices MAX31760 Fan-Speed Controller
> > > 
> > > Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx>
> > > ---
> > >  .../bindings/hwmon/adi,max31760.yaml          | 44 +++++++++++++++++++
> > >  1 file changed, 44 insertions(+)
> > >  create mode 100644 
> > > Documentation/devicetree/bindings/hwmon/adi,max31760.yaml
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > ./Documentation/devicetree/bindings/hwmon/adi,max31760.yaml: error 
> > checking schema file
> 
> Not sure why the error is useless ATM. I'm checking that.
> 
> The problem is that 'reg' is a matrix and you need to either fully define it or use the simplified form for a single cell:
> 
> reg:
>   minimum: 0x50
>   maximum: 0x57
> 
> The full, expanded form is:
> 
> reg:
>   items:
>     - items:
>         - minimum: 0x50
>           maximum: 0x57
> 

Actually it passes the check when I remove maxItems property:

  reg:
    description: I2C address of slave device.
    items:
      minimum: 0x50
      maximum: 0x57

I cannot find a way to specify both maxItems and min-max limits.
Which one should I drop? Line below is from the output of dt_bindigs_check:

hint: "maxItems" is not needed with an "items" list

Regards,
Ibrahim

> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/binding
> > s/hwmon/adi,max31760.yaml: ignoring, error in schema: properties: reg
> 
> > Documentation/devicetree/bindings/hwmon/adi,max31760.example.dtb:0:0: 
> > /example-0/i2c/fan-controller@50: failed to match any schema with 
> > compatible: ['adi,max31760']
> 
> This will go away when the schema passes checks.
> 
> Rob




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux