On 09/09/2022 18:47, Rob Herring wrote: > On Fri, Sep 09, 2022 at 11:26:29AM -0500, Rob Herring wrote: >> On Fri, 09 Sep 2022 16:37:17 +0300, Ibrahim Tilki wrote: >>> Adding bindings for Analog Devices MAX31760 Fan-Speed Controller >>> >>> Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx> >>> --- >>> .../bindings/hwmon/adi,max31760.yaml | 44 +++++++++++++++++++ >>> 1 file changed, 44 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/hwmon/adi,max31760.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> ./Documentation/devicetree/bindings/hwmon/adi,max31760.yaml: error checking schema file > > Not sure why the error is useless ATM. I'm checking that. > > The problem is that 'reg' is a matrix and you need to either fully > define it or use the simplified form for a single cell: > > reg: > minimum: 0x50 > maximum: 0x57 I think this was in v7, so I understand that schema in that case expects the third option from anyOf - #/single? https://github.com/devicetree-org/dt-schema/blob/main/dtschema/meta-schemas/cell.yaml#L62 Best regards, Krzysztof
