Hi Aleksa, I love your patch! Yet something to improve: [auto build test ERROR on groeck-staging/hwmon-next] [also build test ERROR on next-20220901] [cannot apply to linus/master v6.0-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Aleksa-Savic/hwmon-aquacomputer_d5next-Add-support-for-Aquacomputer-High-Flow-Next/20220905-222744 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next config: i386-randconfig-a002 (https://download.01.org/0day-ci/archive/20220906/202209061853.1eqL4nKA-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/0a43ba8acd8bcd54afd03ea6149d54fc99fe284c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Aleksa-Savic/hwmon-aquacomputer_d5next-Add-support-for-Aquacomputer-High-Flow-Next/20220905-222744 git checkout 0a43ba8acd8bcd54afd03ea6149d54fc99fe284c # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kvm/ drivers/hwmon/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/hwmon/aquacomputer_d5next.c:38:3: error: use of undeclared identifier 'highflownext' [highflownext] = "highflownext" ^ drivers/hwmon/aquacomputer_d5next.c:425:8: error: use of undeclared identifier 'highflownext' case highflownext: ^ drivers/hwmon/aquacomputer_d5next.c:443:8: error: use of undeclared identifier 'highflownext' case highflownext: ^ drivers/hwmon/aquacomputer_d5next.c:465:8: error: use of undeclared identifier 'highflownext' case highflownext: ^ drivers/hwmon/aquacomputer_d5next.c:736:7: error: use of undeclared identifier 'highflownext' case highflownext: ^ >> drivers/hwmon/aquacomputer_d5next.c:924:7: error: use of undeclared identifier 'USB_PRODUCT_ID_HIGHFLOWNEXT' case USB_PRODUCT_ID_HIGHFLOWNEXT: ^ drivers/hwmon/aquacomputer_d5next.c:925:16: error: use of undeclared identifier 'highflownext' priv->kind = highflownext; ^ drivers/hwmon/aquacomputer_d5next.c:993:47: error: use of undeclared identifier 'USB_PRODUCT_ID_HIGHFLOWNEXT' { HID_USB_DEVICE(USB_VENDOR_ID_AQUACOMPUTER, USB_PRODUCT_ID_HIGHFLOWNEXT) }, ^ >> drivers/hwmon/aquacomputer_d5next.c:997:1: error: definition of variable with array type needs an explicit size or an initializer MODULE_DEVICE_TABLE(hid, aqc_table); ^ include/linux/module.h:244:21: note: expanded from macro 'MODULE_DEVICE_TABLE' extern typeof(name) __mod_##type##__##name##_device_table \ ^ <scratch space>:196:1: note: expanded from here __mod_hid__aqc_table_device_table ^ 9 errors generated. vim +/highflownext +38 drivers/hwmon/aquacomputer_d5next.c 31 32 static const char *const aqc_device_names[] = { 33 [d5next] = "d5next", 34 [farbwerk] = "farbwerk", 35 [farbwerk360] = "farbwerk360", 36 [octo] = "octo", 37 [quadro] = "quadro", > 38 [highflownext] = "highflownext" 39 }; 40 -- 0-DAY CI Kernel Test Service https://01.org/lkp
