On Thu, Aug 25, 2022 at 5:02 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > On Thu, Aug 25, 2022 at 04:37:36PM +0200, Andreas Böhler wrote: > > The tps23861 driver does not initialize the chip and relies on it being > > in auto-mode by default. On some devices, these controllers default to > > OFF-Mode and hence cannot be used at all. > > > > This brings minimal support for initializing the controller in a user- > > defined mode. > > > > Signed-off-by: Andreas Böhler <dev@xxxxxxxxxxx> > > nack for the series, sorry. The suggested properties are not hardware > monitoring but phy properties. There should be a separate phy driver > to manage those. > > Also, as mentioned, the hwmon 'enable' attribute is abused to control > port functionality and should be removed. Hi Guenter, Are you referring to an ethernet PHY driver or the generic PHY framework? Regards, Robert > > Guenter -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@xxxxxxxxxx Web: www.sartura.hr
