On Fri, Aug 19, 2022 at 4:03 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > On Fri, Aug 19, 2022 at 12:50:46PM +0300, Andy Shevchenko wrote: > > On Fri, Aug 19, 2022 at 2:52 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > > On Sat, Jul 30, 2022 at 03:50:24PM +0300, Andy Shevchenko wrote: ... > > > > Add mod_devicetable.h include. > > > > > > > What does that have to do with this patch ? > > > > See below. > > > > > > +#include <linux/mod_devicetable.h> > > > > > > -#include <linux/of.h> > > > > The of.h implicitly included missed headers. The mod_devicetable.h is > > necessary when we drop of.h. OTOH I haven't checked if > > mod_devicetable.h is still included indirectly. Either way the correct > > approach is to include mod_devicetable.h since we use a data type from > > it (of_device_id IIRC). > > > Something like > > "Include mod_devicetable.h explicitly to replace the dropped of.h which > included mod_devicetable.h indirectly" > > might be useful. Sure, I will add it in v2. Thanks for review! -- With Best Regards, Andy Shevchenko
