On Fri, Aug 19, 2022 at 2:52 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > On Sat, Jul 30, 2022 at 03:50:24PM +0300, Andy Shevchenko wrote: > > Convert the module to be property provider agnostic and allow > > it to be used on non-OF platforms. > > > > Add mod_devicetable.h include. > > > What does that have to do with this patch ? See below. > > +#include <linux/mod_devicetable.h> > > -#include <linux/of.h> The of.h implicitly included missed headers. The mod_devicetable.h is necessary when we drop of.h. OTOH I haven't checked if mod_devicetable.h is still included indirectly. Either way the correct approach is to include mod_devicetable.h since we use a data type from it (of_device_id IIRC). -- With Best Regards, Andy Shevchenko
