On Wed, Aug 10, 2022 at 03:56:08PM -0700, Zev Weiss wrote: > > > > I thought about calling it in probe, but I don't really like it because > > it would slow down boot. > > True, that's a fair point. > > > Let's introduce a namespace (say, NCT6775) instead. > > Change all EXPORT_SYMBOL_GPL(x) to EXPORT_SYMBOL_NS_GPL(x, NCT6775) and > > add MODULE_IMPORT_NS(NCT6775) to nct6775-platform.c and nct6775-i2c.c. > > This will ensure that the exported symbols can only be called from the > > nct6775 code. > > > > nct6775-core.c currently has DEFAULT_SYMBOL_NAMESPACE #defined to > HWMON_NCT6775 (and the platform and i2c drivers are using > MODULE_IMPORT_NS(HWMON_NCT6775)), so I think that's already in place -- I > guess we can just leave it as is with the patch that's now upstream then. > Excellent, looks like we are all set. Thanks, Guenter
