RE: [v3 2/3] dt-bindings: hwmon: lm90: add ti,extended-range-enable property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >> On 17/05/2022 09:57, Holger Brunck wrote:
> >>> Some devices can operate in an extended temperature mode.
> >>> Therefore add a boolean ti,extended-range-enable to be able to
> >>> select this feature in the device tree node. Also make sure that
> >>> this feature can only be enabled for the devices supporting this feature.
> >>>
> >>> Signed-off-by: Holger Brunck <holger.brunck@xxxxxxxxxxxxxxxxx>
> >>> ---
> >>> changes for v3:
> >>>   - rename property to ti,extended-range-enable
> >>>   - use allOf:if to check if the device supports this feature
> >>>   - rephrase commit msg
> >>
> >> Please use standard email subjects, so with the PATCH keyword in the
> title.
> >> `git format-patch` helps here to create proper versioned patch.
> >
> > I did this but I used only "--subject-prefix=v3" instead of
> > "--subject-prefix="PATCH v3". I will change that for the next version.
> 
> Before sending you can always review the mails. The easiest is anyway "git
> format-patch -3 -v3"
> 

thanks, the -v3 option I didn't know.
 
> >
> >> Skipping it makes filtering of emails more difficult thus making the
> >> review process less convenient.
> >>
> >
> > yes.
> >
> >> Then use standard email-sending tools to properly thread your patchset.
> >> git send-email for example. Kernel docs also explain this.
> >>
> >
> > I used "git send-email" but I guess my problem was that I was sending
> > patch per patch as I had a  different set of recipients in the CC list.
> 
> The recipients list should be the same, why it's different set?
> 

I thought the changes in driver code is not relevant to the persons reviewing
the DT bindings part. But I will change that in the next round and keep the
same cc list for the whole series.

> >
> >> Currently, this patchset is not possible to apply due to missing threading.
> >>
> >
> > Ok. So would "git send-email --to ... --cc ... 000*" take care of
> > correct threading  as it send is handled from one command?
> 
> Yes.
> 
> You can send it also one-by-one with proper threading, if for some reason
> you do not want to follow the easy path. Regardless which way you choose -
> easy or manual - just be sure that effect is correct and the same.
> 

ok I see. Thanks for your help.

Best regards
Holger





[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux