On Thu, Mar 03, 2022 at 04:31:39PM +0100, Agathe Porte wrote: > Le 3/3/2022 à 4:00 PM, Guenter Roeck a écrit : > > On 3/3/22 00:57, Agathe Porte wrote: > > > Hi Guenter, > > > > > > Le 02/03/2022 à 18:59, Guenter Roeck a écrit : > > > > Any review / test feedback on this patch ? I would like to apply it > > > > before the commit window opens, but the time is getting short. > > > > > > I thought that you did receive the TMP464 samples and had the > > > opportunity to test on it. I will test v7 on our hardware equipped > > > with TMP464, verify that DT support works fine, and will reply to > > > this email with my findings. > > > > > > > Yes, I did, and thanks a lot for it! I even wrote a qemu emulation > > for the chip to be able to test the devicetree code. > > Great! > > > Still, I need to have someone else confirm that I didn't mess up. > > I tested v7 on our hardware and the behavior seems to be the same as our > previous, in-house driver, if that gives you a point of comparison. We only > use temp*_input sysfs though. > > No compilation warnings. > > I can disable and enable sensors fine at runtime: > > > # cat temp*_input > > 43063 > > 35813 > > 34938 > > 39313 > > 29125 > > # echo 0 | tee temp*_enable > > 0 > > # cat temp*_input > > cat: temp1_input: No data available > > cat: temp2_input: No data available > > cat: temp3_input: No data available > > cat: temp4_input: No data available > > cat: temp5_input: No data available > > # echo 1 | tee temp*_enable > > 1 > > # cat temp*_input > > 43063 > > 35750 > > 34875 > > 39313 > > 29188 > > For what it's worth: > > Tested-by: Agathe Porte <agathe.porte@xxxxxxxxx> > Thanks a lot! I applied the series to hwmon-next. Guenter
