This data was retrieved from the dellfan utility (https://github.com/clopez/dellfan). The combination is currently not used by default on any models, but users can still select it for testing purposes. Tested on a Dell Insprion 3505. Signed-off-by: Armin Wolf <W_Armin@xxxxxx> --- Documentation/hwmon/dell-smm-hwmon.rst | 7 ++++--- drivers/hwmon/dell-smm-hwmon.c | 5 +++++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/Documentation/hwmon/dell-smm-hwmon.rst b/Documentation/hwmon/dell-smm-hwmon.rst index 564d99cda869..cfaee682a245 100644 --- a/Documentation/hwmon/dell-smm-hwmon.rst +++ b/Documentation/hwmon/dell-smm-hwmon.rst @@ -68,14 +68,15 @@ laptops actually work for yours as well, or that you have to discover new codes. As a first step, you can load the module with the module parameter -``fan_mode_method`` set to 1 to test if your hardware works with -an already know method for disabling automatic BIOS fan control. +``fan_mode_method`` set to 1 or 2 to test if your hardware works with +already know methods for disabling automatic BIOS fan control. If ``pwm1_enable`` is now present and works (i.e., you can manually control the fan speed), then please submit your finding as a kernel patch, so that other users can benefit from it. Just add your model to the list ``i8k_whitelist_fan_control`` in file ``drivers/hwmon/dell-smm-hwmon.c`` in the kernel tree and use -the already known code pair. +the already known code pairs (number of method equals the number of +entry in ``i8k_fan_controls``). Please read :ref:`Documentation/process/submitting-patches.rst <submittingpatches>` for information on submitting patches. diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index 1c4cc516c8b2..3b49e55d060f 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1182,10 +1182,15 @@ struct i8k_fan_control_data { }; enum i8k_fan_controls { + I8K_FAN_30A3_31A3, I8K_FAN_34A3_35A3, }; static const struct i8k_fan_control_data i8k_fan_control_data[] __initconst = { + [I8K_FAN_30A3_31A3] = { + .manual_fan = 0x30a3, + .auto_fan = 0x31a3, + }, [I8K_FAN_34A3_35A3] = { .manual_fan = 0x34a3, .auto_fan = 0x35a3, -- 2.30.2
