On Sun, Sep 12, 2021 at 1:26 AM Denis Pauk <pauk.denis@xxxxxxxxx> wrote: > On Thu, 9 Sep 2021 19:50:02 +0300 > Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote: > > On Thu, Sep 09, 2021 at 12:36:02AM +0300, Denis Pauk wrote: ... > Should it be such ? I don't know, but if so, then SoB of Bernhard is missing below. It's all written in the Submitting Patches document: https://www.kernel.org/doc/html/latest/process/submitting-patches.html > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204807 > Signed-off-by: Denis Pauk <pauk.denis@xxxxxxxxx> > Co-Developed-by: Bernhard Seibold <mail@xxxxxxxxxxxxxxxxxxx> ... > > > + int sioreg; > > > > It should be unsigned short. > Should I change all occurrences of sioreg to unsigned short? > Before my patch it was integer. Ah, then it's fine. Keep the same type then as is. -- With Best Regards, Andy Shevchenko
