Thanks for the feedback! On Thu, 9 Sep 2021 19:50:02 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote: > On Thu, Sep 09, 2021 at 12:36:02AM +0300, Denis Pauk wrote: > > Thanks for your contribution! > My comments below. > > > Rearrange code for directly use struct nct6775_sio_data in superio_* > > functions > > Missed period. > > We refer to the functions as superio_*(). > > The commit message may need more elaboration (why you are doing this). > > > v2: split changes to separate patches > > This should go after '---' (cutter) line below. But entire series > needs: 1) a proper versioning (use `git format-patch -v<n> ...`) > 2) to NOT be a continuation of the previous one (start a new thread!) > 3) to have a cover letter (use `git format-patch --cover-letter`) > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=204807 > > BugLink > > > Signed-off-by: Bernhard Seibold <mail@xxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Denis Pauk <pauk.denis@xxxxxxxxx> > > This is wrong. My understanding that you have to preserve Bernhard's > authorship and add yourself as Co-developer (see Submitting Patches on > how to properly use tags). > > ... Should it be such ? ---- BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204807 Signed-off-by: Denis Pauk <pauk.denis@xxxxxxxxx> Co-Developed-by: Bernhard Seibold <mail@xxxxxxxxxxxxxxxxxxx> ---- > > > +struct nct6775_sio_data { > > > + int sioreg; > > It should be unsigned short. > > > + enum kinds kind; > > +}; > Should I change all occurrences of sioreg to unsigned short? Before my patch it was integer. -- Best regards, Denis.
