Hi, I'm replying here since this series has no cover-letter, for the next version for a series touching so many different sub-systems it would be good to start with a cover-letter providing some background info on the series. I see this is binding to an ACPI device, yet it is also using devicetree bindings and properties. So I take it this means that your ACPI tables are using the optional capability of embedded device-tree blobs inside the ACPI tables ? That is an unusual combination on a x86 device, note it is not wrong but AFAIK you are the first to do this on x86. Other then that question, for the next version please give all commits a proper commit message and not just a short 1 line Subject and put the changelog after a scissors line after your Signed-off-by like this: Signed-off-by: Campion Kang <campion.kang@xxxxxxxxxxxxxxxx> --- Changed in V7: 1. According to the reviewer's comment, add two files: Documentation/hwmon/ahc1ec0-hwmon.rst and drivers/platform/x86/ahc1ec0-core.c And please also include older changelog entries. Regards, Hans On 5/6/21 10:16 AM, Campion Kang wrote: > Changed in V7: > 1. According to the reviewer's comment, add two files: > Documentation/hwmon/ahc1ec0-hwmon.rst and > drivers/platform/x86/ahc1ec0-core.c > > Signed-off-by: Campion Kang <campion.kang@xxxxxxxxxxxxxxxx> > --- > MAINTAINERS | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 83c2b1867586..984795eb6b5d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -572,6 +572,19 @@ S: Maintained > F: Documentation/scsi/advansys.rst > F: drivers/scsi/advansys.c > > +ADVANTECH AHC1EC0 EMBEDDED CONTROLLER DRIVER > +M: Campion Kang <campion.kang@xxxxxxxxxxxxxxxx> > +L: linux-kernel@xxxxxxxxxxxxxxx > +S: Maintained > +F: Documentation/devicetree/bindings/mfd/ahc1ec0.yaml > +F: Documentation/hwmon/ahc1ec0-hwmon.rst > +F: drivers/hwmon/ahc1ec0-hwmon.c > +F: drivers/mfd/ahc1ec0.c > +F: drivers/platform/x86/ahc1ec0-core.c > +F: drivers/watchdog/ahc1ec0-wdt.c > +F: include/dt-bindings/mfd/ahc1ec0-dt.h > +F: include/linux/platform_data/ahc1ec0.h > + > ADVANTECH SWBTN DRIVER > M: Andrea Ho <Andrea.Ho@xxxxxxxxxxxxxxxx> > L: platform-driver-x86@xxxxxxxxxxxxxxx >
