On Wed, 2021-04-21 at 14:09 +0200, Greg KH wrote: > On Wed, Apr 21, 2021 at 01:58:29PM +0200, Hans de Goede wrote: > > Hi, > > > > On 4/21/21 9:51 AM, Matti Vaittinen wrote: > > > On Tue, 2021-03-23 at 15:19 +0100, Greg KH wrote: > > > > On Tue, Mar 23, 2021 at 02:58:28PM +0100, Hans de Goede wrote: > > > > > Hi, > > > > > > > > > > On 3/23/21 2:56 PM, Matti Vaittinen wrote: > > > > > > Devm helper header containing small inline helpers was > > > > > > added. > > > > > > Hans promised to maintain it. > > > > > > > > > > > > Add Hans as maintainer and myself as designated reviewer. > > > > > > > > > > > Ultimately this is up to Greg though, so lets wait and see > > > > > what > > > > > Greg has to say about this. > > > > > > > > Can we move some of the devm_* calls in include/device.h into > > > > here as > > > > well so that you all can be in charge of them instead of me? > > > > > > Seems like this was left w/o answer. I guess the question was > > > pointed > > > to Hans > > > > I believe that Greg was (mostly) joking here. At least that is how > > I interpreted Greg's reply,which is why I did not answer. > > I have no idea what this thread was about anymore, sorry :) Need more B12 ;) Can't remember a minor discussion just a few thousand other patch mails ago? Huh, that's what the age does, right :p Well, this is not urgent in any way but here's some context: > This series implements delayed wq cancellation on top of devm and > replaces > the obvious cases where only thing remove call-back in a driver does > is > cancelling the work. There might be other cases where we could switch > more than just work cancellation to use managed version and thus get > rid > of remove or mixed (manual and devm) resource management. > > The series introduces include/linux/devm-helpers.h file which > hopefully works as a place where this kind of helpers can be inlined. and your reply: > Can we move some of the devm_* calls in include/device.h into here > as well ... I thought you meant that literally, Hans assumed you were joking - and you don't remember how it was :] So - if no further suggestions, then we keep the devm stuff which is currently in device.h still in device.h. Although the malloc/free stuff is not really strictly device thing. Best Regards Matti Vaittinen
