On Tue, 2021-03-23 at 15:19 +0100, Greg KH wrote: > On Tue, Mar 23, 2021 at 02:58:28PM +0100, Hans de Goede wrote: > > Hi, > > > > On 3/23/21 2:56 PM, Matti Vaittinen wrote: > > > Devm helper header containing small inline helpers was added. > > > Hans promised to maintain it. > > > > > > Add Hans as maintainer and myself as designated reviewer. > > > > > Ultimately this is up to Greg though, so lets wait and see what > > Greg has to say about this. > > Can we move some of the devm_* calls in include/device.h into here as > well so that you all can be in charge of them instead of me? Seems like this was left w/o answer. I guess the question was pointed to Hans - but what comes to my (not always so humble) opinion - most of the devm functions in device.h are tightly related to the device interface or devres. Thus the device.h feels like appropriate place for most of those. OTOH, the kmalloc/kfree related functions, strdub and kmemdub might be candidates for move - those are not really "device things". But this is really not my call :) Best Regards Matti Vaittinen -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND
