[AMD Official Use Only - Approved for External Use] Hi Sandeep, >> Sure, I'll run that test. I have a 3900X though, which is 12 core, so do I have to adjust anything for that CPU, or just run with the parameters you've specified? I'm trying to get hold of a system to test it myself. In the meanwhile, you may run the following command in the back ground and read the counters (cores and socket) at 5 to 10 secs apart and sum of the diff of core counters should be not be > diff of socket counters sudo ./avx-turbo --iters 1000000000 --spec avx256_fma_t/12 You may refer https://www.spinics.net/lists/linux-hwmon/msg08255.html link for more background of the testing. Regards, Naveenk -----Original Message----- From: Sandeep <sandy.8925@xxxxxxxxx> Sent: Wednesday, December 9, 2020 8:24 PM To: Chatradhi, Naveen Krishna <NaveenKrishna.Chatradhi@xxxxxxx> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>; linux-hwmon@xxxxxxxxxxxxxxx Subject: Re: [PATCH] Add support for Zen 2 CPUs to amd_energy driver [CAUTION: External Email] On Wed, 9 Dec 2020 at 16:33, Chatradhi, Naveen Krishna <NaveenKrishna.Chatradhi@xxxxxxx> wrote: > > [AMD Official Use Only - Approved for External Use] > > Hi Guenter, > > >> This patch will require an Ack from Naveen; support for this model > >> was previously removed due to inconsistent results; see commit > >> f28e360f2903 > ("hwmon: (amd_energy) match for supported models"), I could not get > hold of a board with the mentioned processor. > > Sandeep, > > Earlier, we noticed on some of the family 17h processors the core and socket energy counters are not well calibrated. > > While running avx-turbo work load > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftravisdowns%2Favx-turbo&data=04%7C01%7CNaveenKrishna.Chatradhi%40amd.com%7C8cd70f66176547ea9d8208d89c525af5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637431224816944682%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=mJmMnL3Y4Wwi%2BLCqZmn9AjxGeIKdxgoLrjz%2FqASnl68%3D&reserved=0 as below, we noticed that for a given time, the sum of the energy consumed by all the cores in a socket is greater than the energy consumed by the socket itself. > > Can you run the avx-turbo test, with following options and confirm the results ? > > ./avx-turbo --iters 10000000 --spec avx256_fma_t/8 > > This will run AVX code on all 8 cores for about 1 second. To run it for longer, increase the --iters argument. > > Regards, > Naveenk Sure, I'll run that test. I have a 3900X though, which is 12 core, so do I have to adjust anything for that CPU, or just run with the parameters you've specified? - Sandeep
