[AMD Official Use Only - Approved for External Use]
Hi Guenter,
>> This patch will require an Ack from Naveen; support for this model was previously removed due to inconsistent results; see commit f28e360f2903
("hwmon: (amd_energy) match for supported models"),
I could not get hold of a board with the mentioned processor.
Sandeep,
Earlier, we noticed on some of the family 17h processors the core and socket energy counters are not well calibrated.
While running avx-turbo work load https://github.com/travisdowns/avx-turbo as below, we noticed that for a given time,
the sum of the energy consumed by all the cores in a socket is greater than the energy consumed by the socket itself.
Can you run the avx-turbo test, with following options and confirm the results ?
./avx-turbo --iters 10000000 --spec avx256_fma_t/8
This will run AVX code on all 8 cores for about 1 second. To run it for longer, increase the --iters argument.
Regards,
Naveenk
-----Original Message-----
From: Guenter Roeck <linux@xxxxxxxxxxxx>
Sent: Wednesday, December 9, 2020 2:11 AM
To: Sandeep Raghuraman <sandy.8925@xxxxxxxxx>
Cc: linux-hwmon@xxxxxxxxxxxxxxx; Chatradhi, Naveen Krishna <NaveenKrishna.Chatradhi@xxxxxxx>
Subject: Re: [PATCH] Add support for Zen 2 CPUs to amd_energy driver
[CAUTION: External Email]
On Wed, Dec 09, 2020 at 01:51:48AM +0530, Sandeep Raghuraman wrote:
> This patch adds support for Zen 2 desktop CPUs to the amd_energy driver.
>
> Signed-off-by: Sandeep Raghuraman <sandy.8925@xxxxxxxxx>
This patch will require an Ack from Naveen; support for this model was previously removed due to inconsistent results; see commit f28e360f2903
("hwmon: (amd_energy) match for supported models"),
Guenter
> ---
> drivers/hwmon/amd_energy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --
>
> diff --git a/drivers/hwmon/amd_energy.c b/drivers/hwmon/amd_energy.c
> index 0dee535e6c85..21341c8e1d6e 100644
> --- a/drivers/hwmon/amd_energy.c
> +++ b/drivers/hwmon/amd_energy.c
> @@ -363,6 +363,7 @@ static struct platform_device *amd_energy_platdev;
>
> static const struct x86_cpu_id cpu_ids[] __initconst = {
> X86_MATCH_VENDOR_FAM_MODEL(AMD, 0x17, 0x31, NULL),
> + X86_MATCH_VENDOR_FAM_MODEL(AMD, 0x17, 0x71, NULL),
> {}
> };
> MODULE_DEVICE_TABLE(x86cpu, cpu_ids);
