Hi Jean, On Fri, Apr 17, 2020 at 11:55:03AM +0200, Jean Delvare wrote: > Hi Sascha, > > On Fri, 17 Apr 2020 11:28:53 +0200, Sascha Hauer wrote: > > The jc42 driver passes I2C client's name as hwmon device name. In case > > of device tree probed devices this ends up being part of the compatible > > string, "jc-42.4-temp". This name contains hyphens and the hwmon core > > doesn't like this: > > > > jc42 2-0018: hwmon: 'jc-42.4-temp' is not a valid name attribute, please fix > > > > This changes the name to "jc42" which doesn't have any illegal > > characters. > > I don't think "jc-42.4-temp" is a valid i2c client name either. What makes the name invalid then? I am not aware of any constraints of i2c client names. > I believe this should be fixed at the of->i2c level, rather than the > i2c->hwmon level. Are you suggesting a character conversion from hyphens to underscores or similar in the i2c core? > Not sure how other drivers are dealing with that, it > seems that in most cases the name part of the compatible string matches > exactly the expected client name so no conversion is needed. Other i2c hwmon drivers I found do not have any hyphens in their compatible string, so they are at least not hit by this message. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
