Hi Sascha, On Fri, 17 Apr 2020 11:28:53 +0200, Sascha Hauer wrote: > The jc42 driver passes I2C client's name as hwmon device name. In case > of device tree probed devices this ends up being part of the compatible > string, "jc-42.4-temp". This name contains hyphens and the hwmon core > doesn't like this: > > jc42 2-0018: hwmon: 'jc-42.4-temp' is not a valid name attribute, please fix > > This changes the name to "jc42" which doesn't have any illegal > characters. I don't think "jc-42.4-temp" is a valid i2c client name either. I believe this should be fixed at the of->i2c level, rather than the i2c->hwmon level. Not sure how other drivers are dealing with that, it seems that in most cases the name part of the compatible string matches exactly the expected client name so no conversion is needed. Thanks, -- Jean Delvare SUSE L3 Support
