On 4/1/20 12:02 AM, Pali Rohár wrote:
Hello! I'm fine with any coding style which is consistent. With or also without this blank line. So if Jean and Guenter as subsystem maintainers want this change I'm fine with it too and in this case you can add my Acked-by: Pali Rohár <pali@xxxxxxxxxx>
I'm just wandering why this warnings are appearing? WARNING: Missing a blank line after declarations #122: FILE: drivers/hwmon/dell-smm-hwmon.c:122: + unsigned int eax; + unsigned int ebx __packed; WARNING: Missing a blank line after declarations #123: FILE: drivers/hwmon/dell-smm-hwmon.c:123: + unsigned int ebx __packed; + unsigned int ecx __packed; WARNING: Missing a blank line after declarations #124: FILE: drivers/hwmon/dell-smm-hwmon.c:124: + unsigned int ecx __packed; + unsigned int edx __packed; WARNING: Missing a blank line after declarations #125: FILE: drivers/hwmon/dell-smm-hwmon.c:125: + unsigned int edx __packed; + unsigned int esi __packed; WARNING: Missing a blank line after declarations #126: FILE: drivers/hwmon/dell-smm-hwmon.c:126: + unsigned int esi __packed; + unsigned int edi __packed; They definitely look false positives, so maybe this behavior should be reported to the maintainers of the checkpatch.pl script?
