On Tuesday 31 March 2020 23:57:08 Michele Sorcinelli wrote:
> Fix missing blank line after declaration: reported by checkpatch.pl
>
> There are other missing blank lines reported in the declaration of
> struct smm_regs fields (line 120) but they are probably false positives
> so I don't think they need to be changed.
>
> Signed-off-by: Michele Sorcinelli <michelesr@xxxxxxxxxxxxx>
Hello! I'm fine with any coding style which is consistent. With or also
without this blank line. So if Jean and Guenter as subsystem maintainers
want this change I'm fine with it too and in this case you can add my
Acked-by: Pali Rohár <pali@xxxxxxxxxx>
> ---
> drivers/hwmon/dell-smm-hwmon.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index ab719d372b0d..7b61b613aff6 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1276,6 +1276,7 @@ static int __init i8k_probe(void)
> id = dmi_first_match(i8k_dmi_table);
> if (id && id->driver_data) {
> const struct i8k_config_data *conf = id->driver_data;
> +
> if (!fan_mult && conf->fan_mult)
> fan_mult = conf->fan_mult;
> if (!fan_max && conf->fan_max)
> --
> 2.26.0
>
