2019年11月24日(日) 23:57 Andy Shevchenko <andy.shevchenko@xxxxxxxxx>: > > On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote: > > > > There are several helper macros to convert kelvin to/from Celsius in > > <linux/thermal.h> for thermal drivers. These are useful for any other > > drivers or subsystems, but it's odd to include <linux/thermal.h> just for > > the helpers. > > > > This adds a new <linux/temperature.h> that provides the equivalent inline > > functions for any drivers or subsystems. It is intended to replace the > > helpers in <linux/thermal.h>. > > > > Cc: Sujith Thomas <sujith.thomas@xxxxxxxxx> > > Cc: Darren Hart <dvhart@xxxxxxxxxxxxx> > > Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx> > > Cc: Zhang Rui <rui.zhang@xxxxxxxxx> > > Cc: Eduardo Valentin <edubezval@xxxxxxxxx> > > Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> > > Cc: Amit Kucheria <amit.kucheria@xxxxxxxxxxxxx> > > Cc: Jean Delvare <jdelvare@xxxxxxxx> > > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > > Cc: Keith Busch <kbusch@xxxxxxxxxx> > > Cc: Jens Axboe <axboe@xxxxxx> > > Cc: Christoph Hellwig <hch@xxxxxx> > > Cc: Sagi Grimberg <sagi@xxxxxxxxxxx> > > Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> > > --- > > include/linux/temperature.h | 39 +++++++++++++++++++++++++++++++++++++++ > > > include/linux/thermal.h | 1 + > > > > --- a/include/linux/thermal.h > > +++ b/include/linux/thermal.h > > @@ -14,6 +14,7 @@ > > #include <linux/idr.h> > > #include <linux/device.h> > > #include <linux/sysfs.h> > > +#include <linux/temperature.h> > > #include <linux/workqueue.h> > > #include <uapi/linux/thermal.h> > > I don't see any users of it. Why did you include? The rest of this patch series starts using it. I decided to include <linux/temperature.h> from <linux/thermal.h> because the existing <linux/thermal.h> provides the conversion helpers. However, not all of the thermal drivers require these conversion helpers, so we can change to include <linux/temperature.h> from each thermal driver instead of including it from <linux/thermal.h>. Which way do you prefer?
