On Thu, Nov 21, 2019 at 06:27:12AM -0800, Guenter Roeck wrote: > On Thu, Nov 21, 2019 at 10:48:21PM +0900, Akinobu Mita wrote: > > 2019年11月21日(木) 3:48 Christoph Hellwig <hch@xxxxxx>: > > > > > > On Fri, Nov 15, 2019 at 12:40:00AM +0900, Akinobu Mita wrote: > > > > +/* These macros should be moved to linux/temperature.h */ > > > > +#define MILLICELSIUS_TO_KELVIN(t) DIV_ROUND_CLOSEST((t) + 273150, 1000) > > > > +#define KELVIN_TO_MILLICELSIUS(t) ((t) * 1000L - 273150) > > > > > > Didn't we want to move this to a generic header? > > > > Yes. I start preparing for <linux/temperature.h>. > > Once the change is accepted, I'll move the macros to the header. > > I agree, it is better to keep that change separate. I've added these two patches as-is for the next nvme-5.5 pull request.