On Fri, Nov 15, 2019 at 12:40:00AM +0900, Akinobu Mita wrote: > +/* These macros should be moved to linux/temperature.h */ > +#define MILLICELSIUS_TO_KELVIN(t) DIV_ROUND_CLOSEST((t) + 273150, 1000) > +#define KELVIN_TO_MILLICELSIUS(t) ((t) * 1000L - 273150) Didn't we want to move this to a generic header? Otherwise this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>