Re: [PATCH v3 0/2] hwmon: Add driver for Texas Instruments TMP512/513 sensor chips

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 03, 2019 at 06:35:51PM +0000, Tremblay, Eric wrote:
> > Version three of the driver for Texas Instruments TMP512/513 sensors.
> > 
> > Thanks again for the review, I think we are getting close. I'm not in an easy position for now to test the driver without device tree. I
> > can put the required effort to
> 
> Sorry, I mean that I'm not in a good position to test it, but I can put the required effort to if needed.

All you would need to do is to use device_ API functions instead of
of_device_ API functions, so I can not entirely follow your logic.

Guenter

> > 
> > Main changes from version 2:
> > 	- Remove the neccessity to provide a shunt-resistor value
> > 	- Remove max-expected-current-ma configuration and always
> > 	  use max possible current for calibration
> > 	- Make sure calculation during calibration can't overflow
> > 	- Add value clamping for DT value and runtime parameters
> > 	- Support non DT system
> > 	- Move hysteresis from DT to standard attribute
> > 
> > Main changes from version 1:
> > 	- Use the with_info API instead of sysfs attributes.
> > 	- Remove non-standard attributes and raw value.
> > 	- Move settings that were non-standard attributes to
> > 	  device tree, update documentation as well.
> > 	- Fix coding style issues
> > 
> > Eric Tremblay (2):
> >   Add driver for Texas Instruments TMP512/513 sensor chips.
> >   Add DT bindings for TMP513 driver
> > 
> >  .../devicetree/bindings/hwmon/tmp513.txt      |  33 +
> >  Documentation/hwmon/tmp513.rst                | 102 ++
> >  MAINTAINERS                                   |   7 +
> >  drivers/hwmon/Kconfig                         |  10 +
> >  drivers/hwmon/Makefile                        |   1 +
> >  drivers/hwmon/tmp513.c                        | 901 ++++++++++++++++++
> >  include/linux/platform_data/tmp513.h          |  28 +
> >  7 files changed, 1082 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/tmp513.txt
> >  create mode 100644 Documentation/hwmon/tmp513.rst  create mode 100644 drivers/hwmon/tmp513.c  create mode 100644
> > include/linux/platform_data/tmp513.h
> > 
> > --
> > 2.17.1
> 



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux