From: Iker Perez del Palomar Sustatxa <iker.perez@xxxxxxxxxxxxxxx> Hello, I have been working in the lm75.c driver, trying to add a variable update_time to the tmp75b device. I am not very confident about, if what I am doing and how I am doing it is the best way it could be done. For that reason, I decided to send my current changes, so maybe I could be helped and my code revised. I decided to separate my all my changes in probably more than needed commits because I thought that it would b easier to understand at first place. After the feedback and my changes are ready to submit I will squash the ones that are related between them and the patch series will be much shorter. Thanks in advance for your help, Regards, Iker Iker Perez del Palomar Sustatxa (5): hwmon: (lm75) Add kind field to struct lm75_data hwmon: (lm75) Include hwmon_chip in the permitted types to be writen hwmon: (lm75) Give write permission to hwmon_chip_update_interval hwmon: (lm75) Create function from code to write into registers First approach to sample time writing method drivers/hwmon/lm75.c | 166 +++++++++++++++++++++++++++++++++------------------ 1 file changed, 108 insertions(+), 58 deletions(-) -- 2.11.0