Re: [PATCH] hwmon: Correct struct allocation style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Jun 27, 2019 at 05:27:38PM +0200, Fabian Schindlatz wrote:
> Use sizeof(*var) instead of sizeof(struct var_type) as argument to
> kalloc() and friends to comply with the kernel coding style.
> 
> Co-developed-by: Thomas Röthenbacher <thomas.roethenbacher@xxxxxx>
> Signed-off-by: Thomas Röthenbacher <thomas.roethenbacher@xxxxxx>
> Signed-off-by: Fabian Schindlatz <fabian.schindlatz@xxxxxx>
> [groeck: Resolved comment conflict against -next]
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

This patch causes conflicts in -next due to commit 835896a59b95
("hwmon/coretemp: Cosmetic: Rename internal variables to zones
from packages"), which is not being submitted through the hwmon
subsystem. Unfortunately, the conflicts are more substantial than
I thought and not trivial. Since I have no control over the
conflicting patch, I decided to drop this patch from the hwmon
subsystem commit queue.

Please feel free to resubmit after the commit window closes.
I would suggest to drop the coretemp driver from the patch since
I don't know if further changes outside my control will be made
to that driver.

Sorry for the trouble.

Guenter



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux